chore: Address flakey online retrieval test #4698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Howley <howley.robert@gmail.com>
robhowley
commented
Oct 25, 2024
Comment on lines
+509
to
+522
| @pytest.mark.integration | ||
| @pytest.mark.universal_online_stores(only=["redis", "postgres"]) | ||
| async def test_async_online_retrieval_with_event_timestamps( | ||
| environment, universal_data_sources | ||
| ): | ||
| await _do_async_retrieval_test(environment, universal_data_sources) | ||
|
|
||
|
|
||
| @pytest.mark.integration | ||
| @pytest.mark.universal_online_stores(only=["dynamodb"]) | ||
| async def test_async_online_retrieval_with_event_timestamps_dynamo( | ||
| environment, universal_data_sources | ||
| ): | ||
| await _do_async_retrieval_test(environment, universal_data_sources) |
There was a problem hiding this comment.
@franciscojavierarceo trying to test the theory here ... im not familiar w how the environment reuse works exactly, but if is then separating the tests should work. unless it's cached across tests and not just within a test.
franciscojavierarceo
approved these changes
Oct 25, 2024
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Misc